Perform ingester pushes in a background context rather than the request context #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60422d8 to
6c4d909
Compare
bboreham
reviewed
Mar 7, 2018
pkg/distributor/distributor.go
Outdated
| @@ -350,7 +351,14 @@ func (d *Distributor) Push(ctx context.Context, req *client.WriteRequest) (*clie | |||
| defer cancel() // cancel the timeout to release resources | |||
| for ingester, samples := range samplesByIngester { | |||
| go func(ingester *ring.IngesterDesc, samples []*sampleTracker) { | |||
| d.sendSamples(ctx, ingester, samples, &pushTracker) | |||
| // Use a background context to make sure all ingesters get samples even if we return early | |||
| localCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second) | |||
There was a problem hiding this comment.
Do we still need the WithTimeout on line 350?
Could we use the same timeout parameter?
There was a problem hiding this comment.
It may well be the cancel() on line 351 that is causing the trouble, so it may not be necessary to start from Background() if you took that out.
There was a problem hiding this comment.
I like removing WithTimeout on line 350 and using the same timeout parameter for the background calls.
I believe if we don't have the background context, the context from our request is cancelled as soon as the response is returned.
bboreham
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a background context for the pushes to the ingester. This allows the context to continue after the request is returned in order to finish writing to
replicasingesters, rather than stopping after a quorum.Solution to: #730
Alternative to: #732
Jaeger trace showing the third push finishing after the request is done:
