Extend replication when instance heartbeat timeout #4493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lanmengran1 <lanmengran1@jd.com>
9ae157c to
975d051
Compare
|
I want to know is this a real problem? If not I will close it then |
|
Hi, thanks for your PR; unfortunately it is against the design of Cortex. The reasons we don't do anything like this are:
It may be that you are trying to address the issue at #1521; better to join in there before contributing code. |
|
Thanks for your reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lanmengran1 lanmengran1@jd.com
What this PR does:
Currently, there is an occasion that ingester extend writes not work. If an ingester instance is in Unhealthy state for som reason, where it's actually heartbeat timeout but stay in ACTIVE state in ring desc. In such case, extend writes will not work.
It is reasonable to treat the instance state as LEFT when calling ShouldExtendReplicaSetOnState
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]