return ErrStorageObjectNotFound when object requested for download is not found in Azure blob storage #4200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
When
GetObject
method is called on any of the object stores and the object is not there in the storage then we returnErrStorageObjectNotFound
which is not the case for azure blob storage. This PR makes the required changes to make it consistent with other stores.I have copied some of the code from thanos for the checks https://github.com/thanos-io/thanos/blob/main/pkg/objstore/azure/azure.go#L179