Handle cache-control headers also during a partial cache hit. #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
pstibrany
approved these changes
Apr 6, 2020
Of course @pstibrany ! |
GiedriusS
reviewed
Apr 7, 2020
There was a problem hiding this comment.
Sorry for the late response. Thanks for this! This probably has saved some headaches for me because we were about to try this out. Only the last bits which enable most of the use-cases for Thanos of caching had been merged recently so I haven't run this code in production yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading this code and realize that #1974 missed a place where we also query downstream for partial result in case of partial cache hit.
I've chatted about this with on Thanos dev and suggested to send a fix for them.
/cc @GiedriusS
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com