Fix output directory for copied byproducts

[obsgolem]

CMake doesn't automatically append the config type to the output dir when using a custom command.

[jschwe]

I'm curious what the background of this PR is. Did you experience an issue with a multi-config generator?

[obsgolem]

Yes, I am having an issue where an executable is being copied to my build directory, not my build/Debug (or whatever) directory. This is with the VS generator. Some tests are failing, so I need to see if that is due to it assuming the behavior I was seeing, or if the behavior I was seeing is due to something complex I haven't found yet.

[obsgolem]

Apologies for the lockfile changes, don't know what is up with them. Want me to revert them?

[jschwe]

Sorry for the long delay in reviewing this.

I am having an issue where an executable is being copied to my build directory, not my build/Debug (or whatever) directory. This is with the VS generator. Some tests are failing, so I need to see if that is due to it assuming the behavior I was seeing, or if the behavior I was seeing is due to something complex I haven't found yet.

What kind of tests are failing? Corrosions tests or tests from your project?
I guess changing the default location the artifact is copied to in Multi-Config mode has the potential to break user code, so we would need to document it in the release notes and also give a short reason what this change fixes.

Apologies for the lockfile changes, don't know what is up with them. Want me to revert them?

That would be nice.

[obsgolem]

What kind of tests are failing? Corrosions tests or tests from your project?
I guess changing the default location the artifact is copied to in Multi-Config mode has the potential to break user code, so we would need to document it in the release notes and also give a short reason what this change fixes.

The output directory tests were failing, but after a couple rounds of revision I managed to fix that.

[obsgolem]

Failing test is not due to me I think

[jschwe]

Looking at this again, I noticed that we unconditionally append the config_type now, when the expected behavior is to only append the config_type if the OUTPUT_DIRECTORY variable is not a generator expression

[jschwe]

Thanks! And sorry for the long review times

[obsgolem]

Hey, if you can put up with long times between me responding to review, I can put up with long review times, thanks!