Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-63: Return error if other is nil #64

Merged
merged 4 commits into from
Jan 21, 2024
Merged

gh-63: Return error if other is nil #64

merged 4 commits into from
Jan 21, 2024

Conversation

corona10
Copy link
Owner

@corona10 corona10 commented Jan 21, 2024 •
edited
Loading

closes: gh-63

@corona10 corona10 requested a review from HyeockJinKim January 21, 2024 11:31
HyeockJinKim
HyeockJinKim reviewed Jan 21, 2024
View reviewed changes
imagehash_test.go Outdated Show resolved Hide resolved
imagehash_test.go Outdated Show resolved Hide resolved
HyeockJinKim
HyeockJinKim reviewed Jan 21, 2024
View reviewed changes
imagehash.go Outdated Show resolved Hide resolved
imagehash_test.go Outdated Show resolved Hide resolved
@corona10 corona10 requested a review from HyeockJinKim January 21, 2024 13:09
HyeockJinKim
HyeockJinKim approved these changes Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@HyeockJinKim HyeockJinKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corona10 corona10 merged commit d811588 into master Jan 21, 2024
65 checks passed
@corona10 corona10 deleted the gh-63 branch January 21, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segfault when using non existent image
2 participants
@corona10 @HyeockJinKim