Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to update dependencies, add a new example, and improve the surface rendering functionality. The most important changes include updating
@rspack
dependencies, adding a new surface rendering example, and modifying helper functions for geometry processing.Dependency updates:
package.json
: Updated@rspack/cli
and@rspack/core
to version 1.2.2.New example addition:
packages/tools/examples/surfaceRenderingForTest/index.ts
: Added a new example for surface segmentation representation for volume viewports.Test updates:
tests/surfaceRendering.spec.ts
: Modified the test to use the new examplesurfaceRenderingForTest
and adjusted screenshot parameters.tests/utils/screenShotPaths.ts
: Updated the screenshot path for surface rendering.Helper function improvements:
utils/demo/helpers/createAndCacheGeometriesFromSurfaces.ts
: Refactored the function to process geometries and added a new functioncreateAndCacheGeometriesFromOneSurface
. [1] [2] [3]utils/demo/helpers/downloadSurfacesData.ts
: Added a new functiondownloadOneSurface
to download a single surface.utils/demo/helpers/index.js
: Updated imports to include the new helper functioncreateAndCacheGeometriesFromOneSurface
. [1] [2]