Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TrackballRotateTool): Resolve resolution reduction and refactor code #1306

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Jun 5, 2024

  • Fix reduction of resolution on click of TrackballRotateTool
  • small
  • fix name of example
  • try change listener
  • refactor: Remove unused code and optimize TrackballRotateTool

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for cornerstone-3d-docs canceled.

Name Link
🔨 Latest commit c3ea7af
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/66609f61aeed2d0008c535b7

@sedghi sedghi changed the title fix/resolution fix(TrackballRotateTool): Resolve resolution reduction and refactor code Jun 5, 2024
@sedghi sedghi merged commit 16944fb into main Jun 5, 2024
10 checks passed
@sedghi sedghi deleted the fix/resolution branch January 22, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants