[All] Autowiring #850
Merged
[All] Autowiring #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
178ad6a to
b3556a4
Compare
b3556a4 to
348a80b
Compare
|
rebased to master -> will be released with 2.1 |
…cally apply tags to classes implementing the needed interface for all kinds of Rule Conditions/Actions, Price Calculators, Index/Filters, Contextes. This also allows auto-wiring of coreshop generated services like repositories and manager by using the name of it. Like productRepository` or `storeRepository`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make more use of auto-wiring in symfony 3.4. This will automatically apply tags to classes implementing the needed interface for all kinds of Rule Conditions/Actions, Price Calculators, Index/Filters, Contextes. This also allows auto-wiring of coreshop generated services like repositories and manager by using the name of it. Like productRepository
orstoreRepository`.If a tag is not supplied, but the compiler-pass expects a
type, thetypeis getting auto-generated by the class-name.