Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce theme-bundle #749

Merged
merged 5 commits into from
Dec 17, 2018
Merged

Conversation

dpfaffenbauer
Copy link
Member

@dpfaffenbauer dpfaffenbauer commented Dec 13, 2018

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes

The aim of this bundle is to help making theming in Pimcore easier.

Which uses pimcore-sites to define the themes. StoreBundle than decorates that and changes that to CoreShop stores. ThemeBundle can now be used for Multisite Projects that have to have multiple themes.

TODO:

  • Tests

… pimcore-sites to define the themes. StoreBundle than decorates that and changes that to CoreShop stores. ThemeBundle can now be used for Multisite Projects that have to have multiple themes.
@dpfaffenbauer dpfaffenbauer added this to the 2.1.0 milestone Dec 13, 2018
@dpfaffenbauer dpfaffenbauer self-assigned this Dec 13, 2018
@dpfaffenbauer dpfaffenbauer requested a review from a team December 13, 2018 12:19
@dpfaffenbauer dpfaffenbauer changed the title [StoreBundle, ThemeBundle] Introduce theme-bundle [WIP] Introduce theme-bundle Dec 13, 2018
@dpfaffenbauer dpfaffenbauer changed the title [WIP] Introduce theme-bundle Introduce theme-bundle Dec 17, 2018
@dpfaffenbauer dpfaffenbauer merged commit bfcd2d7 into coreshop:master Dec 17, 2018
@dpfaffenbauer dpfaffenbauer deleted the theme-bundle branch December 17, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant