Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument for re-index command #1219

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Argument for re-index command #1219

merged 1 commit into from
Jan 7, 2020

Conversation

aarongerig
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no

This PR adds an argument to the coreshop:index command, which allows defining certain index IDs to re-index. Default stays the same: all indices get re-indexed.

Additionally, if no indices are found (either by ID lookup or findAll method) a message is displayed in the console.

@dpfaffenbauer dpfaffenbauer merged commit 1197407 into coreshop:2.1 Jan 7, 2020
@dpfaffenbauer
Copy link
Member

thanks @aarongerig

@dpfaffenbauer dpfaffenbauer added this to the 2.1.1 milestone Jan 7, 2020
@dpfaffenbauer dpfaffenbauer self-requested a review January 7, 2020 13:51
@aarongerig aarongerig deleted the feat/index-command-argument branch January 7, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants