Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Variant Unit and QPR Solidifier #1158

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Implement Variant Unit and QPR Solidifier #1158

merged 1 commit into from
Nov 6, 2019

Conversation

solverat
Copy link
Contributor

@solverat solverat commented Nov 4, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #1157

@solverat
Copy link
Contributor Author

solverat commented Nov 4, 2019 •
edited
Loading

image

image

Workflow

  • Pre-Check and inform user about what is going to happen
  • If product has unit definitions, clone them to every getChildren of type variant
  • If product has QPR, clone them
  • If product has QPR with unit definitions, search for same unit name in new object (otherwise the unit definition stays null => defined by __clone)

@solverat solverat changed the title [WIP] Implement Variant Unit and QPR Solidifier Implement Variant Unit and QPR Solidifier Nov 4, 2019
@dpfaffenbauer dpfaffenbauer merged commit 6a618ce into coreshop:master Nov 6, 2019
@solverat solverat deleted the qpr_inherit branch November 7, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpfaffenbauer dpfaffenbauer dpfaffenbauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solverat @dpfaffenbauer