[CoreBundle] support version marshall und unmarshall to merge with existing data #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dpfaffenbauer
commented
Oct 24, 2019
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #1118 |
0de725f to
d8560f1
Compare
solverat
suggested changes
Nov 18, 2019
src/CoreShop/Bundle/ProductBundle/Resources/config/serializer/Model.ProductUnitDefinition.yml
Outdated
Show resolved
Hide resolved
251e8e2 to
fc3767c
Compare
solverat
reviewed
Nov 29, 2019
src/CoreShop/Bundle/ResourceBundle/Serialization/VersionObjectConstructor.php
Outdated
Show resolved
Hide resolved
src/CoreShop/Bundle/ProductBundle/Resources/config/serializer/Model.ProductUnitDefinitions.yml
Outdated
Show resolved
Hide resolved
7c07da1 to
19792c9
Compare
… any in the product
…ine has a managed state, pimcore doesn't. So, in our case, we never should change the state of an entity within the getDataFromEditmode function, since it is possible that the data is not getting flushed to the database. To deal with that problem, we create a temporary entity manager to fetch entites and prepare data for Pimcore. In the save function, we then merge our new entity to the original entity.
…ll more sexy and finally get versions with doctrine running
efc53e4 to
4e9262f
Compare
…oreShop into version-marshall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.