Unit Definition - Precision #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
solverat
commented
Sep 2, 2019
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #1075 |
This PR allows to:
This PR changed:
Frontend
BC BreaksQuantity-Field is now a "text" field and needs to be watched by a javascript helper. There is also a serverside validation. |
dpfaffenbauer
approved these changes
Sep 7, 2019
|
thanks a lot, again. |
dpfaffenbauer
added a commit
to dpfaffenbauer/CoreShop
that referenced
this pull request
Sep 12, 2019
…his happens cause quantity now is a float and now a int anymore.
dpfaffenbauer
added a commit
that referenced
this pull request
Sep 13, 2019
[PriceRules] regression of #1081, force prices to be a int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.