fix: collections not being initialized without User-Agent header

[azurit]

ip and global collections are not initialized for requests without a User-Agent header. This may allow malicious users to bypass rules using these collections.

Fixes #3642.

[fzipi]

Can we write tests for this change?

I mean, for both cases. With and without user-agent.

[azurit]

@fzipi Sure but is there a way how can i know if collections were or were not initialized? How to write a test for it?

[fzipi]

Don't know what to say here. @dune73 do you have a clue on how to test this?

[dune73]

Testing this with ftw is complicated.

If you want to test it, you would need an additional rule that checks for a variable in the collection. If you do not want to do that, then you add a plugin with an effect based on the collection. Like the anti-dos plugin and then you run enough requests to trigger (and kill all subsequent testing).

Honestly, I think we can add a remark here and forget about the testing for the time being, it's not worth the hassle.

[fzipi]

If you can add a comment to the rule then better. If not, I'll just approve.

[azurit]

Sure but what comment?

[dune73]

Proposal:

The creation of the IP and the GLOBAL collection is not being tested as
of this writing due to limits in ftw and our testing setup. 
Proper testing would involve the checking of a variable in the said collections.

[azurit]

Done!