tests/layering-non-root-caps: Adapt to new libcap output #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't deep dive on this, just observed that the new output matches what we laid down. There's ~2.5 years of changes and ~200 commits between 2.28 and 2.48.
|
To clarify this changed in https://bodhi.fedoraproject.org/updates/FEDORA-2021-570cc05441 (see |
jlebon
approved these changes
Feb 16, 2021
| fi | ||
| return | ||
| fi | ||
| # Replace '+' with '='; a libcap change https://bodhi.fedoraproject.org/updates/FEDORA-2021-eeff266a64 |
There was a problem hiding this comment.
That should be https://bodhi.fedoraproject.org/updates/FEDORA-2021-570cc05441, no?
There was a problem hiding this comment.
Have a fix for that queued up in #2583 - let's get this in and unblock CI and avoid another respin?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Feb 16, 2021
From review in coreos#2585 (comment)
openshift-merge-robot
pushed a commit
that referenced
this pull request
Feb 16, 2021
From review in #2585 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't deep dive on this, just observed that the new output
matches what we laid down. There's ~2.5 years of changes
and ~200 commits between 2.28 and 2.48.