This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
dracut/30ignition: general hack cleanups #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
commented
Feb 27, 2019
|
LGTM - can you add |
|
Heh, didn't even notice that one. Done! |
dustymabe
approved these changes
Feb 27, 2019
dustymabe
reviewed
Feb 28, 2019
bgilbert
reviewed
Feb 28, 2019
We're past the MVP phase now. Let's reflect that in our codebase by dropping all the telltale signs of quick hacks and experimentations. This makes the tree nicer to hack on as well. Remember, all your code are belong to Git. We can always revive things as needed as we get around to supporting Packet/DO, etc... Though those units will need to be tweaked anyway. Closes: coreos#33
|
Updated for comments! ⬆️ |
dustymabe
approved these changes
Mar 1, 2019
bgilbert
approved these changes
Mar 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're past the MVP phase now. Let's reflect that in our codebase by
dropping all the telltale signs of quick hacks and experimentations.
This makes the tree nicer to hack on as well.
Remember, all your code are belong to Git. We can always revive things
as needed as we get around to supporting Packet/DO, etc... Though those
units will need to be tweaked anyway.