mantle/kola/tests/crio: update tests for new cri-tools #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42c363c to
45e0bbe
Compare
Cri-tools 1.29[0] now pre-validates container metadata before
running with crictl[1]. The required uid field was missing in our
test causing the following failure.
```
load podSandboxConfig: name, namespace or uid is not in metadata \"&PodSandboxMetadata{Name:rhcos-crio-pod-restart-test,Uid:,Namespace:redhat.test.crio,Attempt:0,}\
```
[0] https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.29.0
[1] kubernetes-sigs/cri-tools#1274
45e0bbe to
14806ec
Compare
|
/lgtm |
jlebon
approved these changes
Dec 14, 2023
|
Nice catch! |
|
/approve |
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cri-tools 1.29[0] now pre-validates container metadata before running with crictl[1]. The required uid field was missing in our test causing the following failure.
[0] https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.29.0
[1] kubernetes-sigs/cri-tools#1274
Fixes: openshift/os#1407