Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildextend-live: make default kargs file look the same #1985

Merged
merged 1 commit into from
Jan 4, 2021
Merged

buildextend-live: make default kargs file look the same #1985

merged 1 commit into from
Jan 4, 2021

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Dec 23, 2020

I.e. make it of length $karg_embed_area_length with the overflow area
being # so that we can use the same function on the coreos-installer
side to read them.

@jlebon jlebon mentioned this pull request Dec 23, 2020
Merged
@jlebon
buildextend-live: make default kargs file look the same
6af00df 
I.e. make it of length `$karg_embed_area_length` with the overflow area
being `#` so that we can use the same function on the coreos-installer
side to read them.
@jlebon
Copy link
Member Author

jlebon commented Jan 4, 2021

This is needed for coreos/coreos-installer#341.

@jlebon
Copy link
Member Author

jlebon commented Jan 4, 2021

Once this is in, I'll open another PR which is mostly a revert of this revert, but conditional on some env var or something so that we can test coreos/coreos-installer#341 in CI.

cgwalters
cgwalters approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b48e428 into coreos:master Jan 4, 2021
@jlebon
Copy link
Member Author

jlebon commented Jan 5, 2021

Once this is in, I'll open another PR which is mostly a revert of this revert, but conditional on some env var or something so that we can test coreos/coreos-installer#341 in CI.

This is part of #1989. (I just made it do feature detection instead.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters approved these changes

@nikita-dubrovskii nikita-dubrovskii Awaiting requested review from nikita-dubrovskii

@darkmuggle darkmuggle Awaiting requested review from darkmuggle

Assignees

@cgwalters cgwalters

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlebon @openshift-ci-robot @cgwalters @openshift-merge-robot