Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store cached hash value when pickling #287

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Do not store cached hash value when pickling #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions immutabledict/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
KeysView,
Mapping,
Optional,
Tuple,
Type,
TypeVar,
ValuesView,
Expand Down Expand Up @@ -45,6 +46,11 @@
setattr(inst, "_hash", None)
return inst

def __reduce__(self) -> Tuple[Any, ...]:
# Do not store the cached hash value when pickling
# as the value might change across Python invocations.
return (self.__class__, (self._dict,))

Check warning on line 52 in immutabledict/__init__.py

View check run for this annotation

Codecov / codecov/patch

immutabledict/__init__.py#L52 

Added line #L52 was not covered by tests

def __getitem__(self, key: _K) -> _V:
return self._dict[key]

Expand Down