Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update web3.js and remove patch-package #86

Closed
wants to merge 6 commits into from
Closed

build: update web3.js and remove patch-package #86

wants to merge 6 commits into from

Conversation

wentokay
Copy link
Collaborator

@wentokay wentokay commented May 27, 2022 •
edited
Loading

thanks to solana-labs/solana#25576 web3.js can now run inside a service worker 👯

what this does

  • ensures web3.js version ^1.43.2 is used across the codebase, as this doesn't have cross-fetch in the browser build
  • removes patch-package as it's not needed anymore

TODO

  • update recoil code to be compatible with new web3.js stuff
  • check that nothing else breaks when forcibly upgrading everything else to 1.43.2+

@wentokay wentokay force-pushed the wen/update-web3.js branch from 337b11c to 51188e7 Compare May 27, 2022 18:28
@wentokay
Copy link
Collaborator Author

build failing because jupiter's recent libraries have issues, will revert to a fixed version

@wentokay wentokay force-pushed the wen/update-web3.js branch 3 times, most recently from 8bdf4df to 349acee Compare June 13, 2022 19:03
@wentokay wentokay force-pushed the wen/update-web3.js branch from 349acee to 1cc118a Compare June 17, 2022 20:20
@johnrees johnrees force-pushed the wen/update-web3.js branch from 1cc118a to ee8134a Compare June 18, 2022 23:02
@johnrees johnrees force-pushed the wen/update-web3.js branch from ee8134a to 56a1127 Compare June 18, 2022 23:28
@wentokay wentokay changed the title [WIP] build: update web3.js and remove patch-package build: update web3.js and remove patch-package Jun 18, 2022
@wentokay wentokay requested a review from armaniferrante June 18, 2022 23:28
@wentokay
Copy link
Collaborator Author

sending SOL seems to work fine on this build

@wentokay wentokay closed this Jun 18, 2022
@wentokay wentokay deleted the wen/update-web3.js branch June 18, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armaniferrante armaniferrante Awaiting requested review from armaniferrante

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wentokay