-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modern jQuery update with support for PHP 8 #759
Merged
spaceisntsyntax
merged 76 commits into
development
from
ERM-63-modern-jquery-update-with-php8
Apr 4, 2024
Merged
Modern jQuery update with support for PHP 8 #759
spaceisntsyntax
merged 76 commits into
development
from
ERM-63-modern-jquery-update-with-php8
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified path to jquery min to https://ajax.googleapis.com/ajax/libs/jquery/3.6.0/jquery.min.js to test breaking changed licensing php to use new CDN version of jquery Modified tooltips to not worry about IE versions UPdated licensing header.php to use CDN jquery commented out browser.msie lines or forced IE = false to handle issue with unsupported .browser.msie added jquery-ui so autocomplete.js would stop squawking removed msie lines from jquery.autocomplete.js fixed issue with commented out lines for msie stuff Changes for browser.lines changes to make thickbox replacement work Changes to make dialog work for upload and for creating a new license changes to make expressions work` More changes to remove thickbox Avoid scroll-to-top caused by href="#" Signed-off-by: root <root@coral-john.eoli.info>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
The scripted CSV export event listener and the Resource->Admin removeData binding was happening too early, before the XHR-loaded HTML was available. This places the binding requests right next to the elements that need them, so timing won't be an issue going forward. Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
…JS event listener binding closer to the intended elements Signed-off-by: Mike Rylander <mrylander@gmail.com>
…rn-jquery-update-with-php8-fixes-WIP Erm 63 modern jquery update with php8 fixes wip
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
…ust match) Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
… 0000-00-00) but leave support for older mysql versions in place Signed-off-by: Mike Rylander <mrylander@gmail.com>
… oversized text Signed-off-by: Mike Rylander <mrylander@gmail.com>
…rn-jquery-update-with-php8-fixes-WIP Erm 63 modern jquery update with php8 fixes wip
Signed-off-by: Mike Rylander <mrylander@gmail.com>
…w-steps ERM-103 Fix arrows not reordering. Listeners attached after html crea…
…103-reorder-workflow-steps
…w-steps ERM-103 Fix arrows not reordering. Listeners attached after html crea…
…rn-jquery-update-with-php8-fixes-WIP JQ syntax changed for checkbox inspection, updating to match
Fixed edit cataloging details issue #ERM-74
Fixed characters encoding issue ERM-116
Fixed utf8 encoding issue ERM-116
Fixed jquery issues on issues tab ERM-107
SUSHI statistics can be retreived from a stored URL, but those are downloaded locally before being processed by the uploadComplete.php script. Because of that, we can simply refuse to load data from URLs using the (local) utf8_fopen_read function, which is only used to load server-local files into memory for processing. Signed-off-by: Mike Rylander <mrylander@gmail.com>
…ading_urls_directly_for_stats Do not process URLs passed directly from users
Export issues & resolve button fix
[747] Updates for jquery datepicker plugin and javascript includes cleanup
Managment - Re-load datepickers after modal instantiation
This was referenced Apr 4, 2024
Closed
spaceisntsyntax
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recent changes all look good, and prior commits have been well tested to date. Let's go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following.