Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualifiers to license Expressions tab for "view only" user #654

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

andyp-uk
Copy link
Contributor

A SirsiDynix customer reported that it is not possible to view the license expression qualifiers on the Expressions tab of the license record if the user has the "view only" privilege. This seems unintentional since the same user can view the qualifier on the Expression Comparison page. Moreover the tool tip for the user admin states "View only users can view all license information, including the license pdf."

This change adds the qualifier to the Expressions tab for users with the "view only" privilege. The option to edit or remove the expression does not appear.

@andyp-uk
Copy link
Contributor Author

Have tested this and can verify the change. It's a small change so I feel confident to merge it even though it's my own work.

@andyp-uk andyp-uk merged commit 26d43f9 into development Aug 13, 2020
@andyp-uk andyp-uk deleted the sirsidynix branch August 13, 2020 14:54
@andyp-uk andyp-uk added the bug This is a bug (not an enhancement) label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is a bug (not an enhancement)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant