Issue 601: Keep search parameters in resource module #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the previously existing behavior that was broken: When going back from a resource detail to the index page using the Home menu link or using the back button of the browser, the search parameters and results are kept.
- Remove debug log
|
I have just tested it on Chrome. It works for almost all the search exept for "fund" and "relationship". |
- Keep fund parameter
Fix the Get Statistics button on a resource page using an absolute URL (/reports/report.php) instead of a relative URL (../reports/report.php) which assumes that coral is installed in the root directory.
- Use subscriptionEndDate
In common/configuration.ini: [settings] open_new_windows = Y/N By default, the links are opened in a new window/tab.
Currently, resources can be filtered with the following relationship criteria: - All: all resources are displayed (child, parent, or no relationship) - Parent: only parent resources are displayed - Child: only child resources are displayed This patch adds the following criteria: - None: only resources that are neither parent nor child are displayed (ie: only resources with no relationship) Test plan: - Perform a search on the resources index page, with 'None' in the Relationship dropdown list. - Check that only the resources with no relationship are displayed.
- Keep relationship parameter
|
Thanks for the feedback @sbouis ! |
|
I'm merging this. |
|
Tested after the rebase, on both Chrome and Firefox, and works as intended! Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background, see Issue #601
This patch fixes the previously existing behavior that was broken:
When going back from a resource detail to the index page using the Home menu
link or using the back button of the browser, the search parameters and results
are kept.
This patch is not very pretty code-wise, so if anyone has a better solution, they're welcome to make another patch.
If not, this can be a quickfix for the time being.