Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 258: Fixes Importing issues #401

Merged
merged 5 commits into from
Apr 6, 2018
Merged

Conversation

queryluke
Copy link
Contributor

Fixes #258

Fixes

Activity type was not stored
Needed attribute added to the stats models (here and here)

SUSHI imports for DB1 did not support Activity Type,
SUSHI import for JR1 incorrectly summed total
Rewrote the parseXML part of the sushi service.

Testing

Import from file

  1. Import a DB1 file.
  2. Activity type should be stored. (I'm not sure where this shows up in the interface, I have been checking directly in the Mysql DB, the coral_usage.MonthlyUsageSummary table)

Example file found in #258
NOTE!! I have trouble importing single year sample files due to a different bug. The other bug is fixed in PR #328. I would advise merging that before testing this fix.

Import from SUSHI

For each report type (JR1, BR1, and DB1)

  1. Setup a sushi platform (can be done for all three at once)
  2. click Run Now button for that platform (can be done for all three at once)
  3. once run, click "View to Process"
  4. Review stats
    • For JR1 & BR1, make sure the YTD values are correct (i.e., correctly summed)
    • For DB1, make sure the activity type column is filled in and there are multiple rows if multiple activity types exist for a single resource.
  5. Click confirm and make sure the stats can be imported to the database.
  6. For DB1 import, make sure activity type is saved in the database.

@jeffnm jeffnm added bug This is a bug (not an enhancement) release blocking labels Apr 5, 2018
@jeffnm jeffnm added this to the Version 3.0.0 Beta milestone Apr 5, 2018
@jeffnm
Copy link
Contributor

jeffnm commented Apr 6, 2018

The issues in #258 appear to be solved by this PR. I'm going to merge #328 and then this one.

@jeffnm jeffnm merged commit 52fc5d4 into coral-erm:development Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is a bug (not an enhancement)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants