Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix type in feature_length #192

Merged
merged 12 commits into from
Jan 19, 2022
Merged

fix type in feature_length #192

merged 12 commits into from
Jan 19, 2022

Conversation

marco-novaes98
Copy link
Contributor

First pull request by Marco as test, just to fix a minor bug

@3rdCore
Copy link
Collaborator

3rdCore commented Jan 19, 2022 •
edited
Loading

your latest commit didn't pass all test sets (red cross next to your commit). This was due to some Core modifications of the direct dependencies ReinforcementLearning.jl, that uses the function ndims to check the dimension of an object before being added to a CircularArrayBuffer, however as we used custom state GraphTrajectoryState, we had to define this function.

The random number generator also changed a bit between Julia v1.6 and v1.7, Ialso added new test sets to handle both cases.

3rdCore
3rdCore reviewed Jan 19, 2022
View reviewed changes
src/RL/representation/default/defaultstaterepresentation.jl Outdated
feature_length(::Type{<:FeaturizedStateRepresentation{DefaultFeaturization, TS}}) where TS <: DefaultTrajectoryState = 3
feature_length(::Type{<:FeaturizedStateRepresentation{DefaultFeaturization, TS}}) where TS = 3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally removed the rapid fix that we proposed yesterday. There was initially no reason to specify the parametric type TS, the error we encountered before could have been the result of an uncanny artifact due to conflict between updated dependencies and our older Julia v1.6...

@marco-novaes98 marco-novaes98 merged commit d31116e into master Jan 19, 2022
@marco-novaes98
Copy link
Contributor Author

All problems have been fixed.

@marco-novaes98 marco-novaes98 deleted the marco branch January 19, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3rdCore 3rdCore 3rdCore left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marco-novaes98 @3rdCore