Fix/dependencies #159
Merged
Fix/dependencies #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I have the repo ready locally, I just need @qcappart approval to upload it 🙂 ) |
|
Yes I agree to have the plotting/non-critical dependencies in another repository. |
qcappart
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to move a few extra functions to a new repository.
Some new features recently added to SeaPearl, brought a lot of new dependencies. These dependencies bring more complexity to the compatibility tree of SeaPearl, despite the fact that they aren't critical to the module. In order to avoid the dependencies of SeaPearl to become too messy, I suggest to create a new repo
SeaPearlExtraswith all the plotting & logging related functions. Thus a user could choose wether or not to load all these additional packages and it would be easier to maintain.