Feature/reward #152
Merged
Feature/reward #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 4, 2021 19:06
3rdCore
commented
Jun 4, 2021
Comment on lines
+21
to
+32
| if symbol == :Infeasible | ||
| lh.reward.value -= 10*model.statistics.numberOfNodes | ||
|
|
||
| elseif symbol == :FoundSolution | ||
| lh.reward.value -= 1 | ||
|
|
||
| elseif symbol == :Feasible | ||
| lh.reward.value -= 1 | ||
|
|
||
| elseif symbol == :BackTracking | ||
| lh.reward.value -= 1 | ||
| end |
There was a problem hiding this comment.
Finally we don't need to declare another function : function set_reward!(::SolutionFoundPhase, ... as the information about the search ( :SolutionFound, :Feasible, :BackTracking ) is already contained in the argument symbol.
We simply need to inform the user that he could implement a reward that can consider different symbols.
Comment on lines
-123
to
-131
| """ | ||
| set_metrics!(PHASE::T, lh::LearnedHeuristic, model::CPModel, symbol::Union{Nothing, Symbol}, x::Union{Nothing, AbstractIntVar}) where T <: LearningPhase | ||
|
|
||
| Call set_metrics!(::SearchMetrics, ...) on env.search_metrics to simplify synthax. | ||
| Could also add it to basicheuristic ! | ||
| """ | ||
| function set_metrics!(PHASE::T, lh::LearnedHeuristic, model::CPModel, symbol::Union{Nothing, Symbol}, x::Union{Nothing, AbstractIntVar}) where T <: LearningPhase | ||
| set_metrics!(PHASE, lh.search_metrics, model, symbol, x::Union{Nothing, AbstractIntVar}) | ||
| end |
There was a problem hiding this comment.
this block of code was simply an interface between LearnedHeuristic and search_metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposition to simplify the use of struct of subtype
LearningPhaseThe
Phaseargument called byvalueselectionheuristic is no longer a element of type...Phase <: LearningPhasebut simply the Type...Phaseitself. That saves an allocation at each step of the search.I also fixed a little bug on the
plotRewardVariationfunction.