CPModification upgrade #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcappart
reviewed
May 26, 2021
kimriouxparadis
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #128, this PR brings new features to ensure the correctness of
prunedDomainsduring each propagation. Thus te mains contributions are:SetModificationto make it possible to track changes in a set domain;addToPrunedDomains!;CPModification, to ensure that each constraint is updating it well.During this work I encountered a few undetected bugs and made some minor changes:
SetEqualConstant;Absoluteto prune values before the beginning of the execution, as this pruning is intractable for the other constraints.If this PR is approved, we should now have a reliable
prunedDomainsvariable, as long as all the new constraints follow a few guidelines. It would be great to write a few instructions about this for potential contributors.Closes #128