Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact Table optimization #138

Merged
merged 3 commits into from
May 21, 2021
Merged

Compact Table optimization #138

merged 3 commits into from
May 21, 2021

Conversation

PierreTsr
Copy link
Contributor

This is the new constructor proposed in #137 with the associated testset.

I first changed the function buildResidues as some supports weren't present in the table when initializing the constraint. But then I figured it would be more efficient to give the constraint already cleaned versions of the supports and table.

The counterpart is that between different instances of the constraint sharing the same instances of table/supports, the variables should initially have the same domains (otherwise the support will be setup incorrectly for some instances).

To sum up, this new constructor gives much more freedom to the user but should be well understood in order not to tigger errors.

Closes #137

@PierreTsr PierreTsr requested a review from qcappart May 20, 2021 23:08
@PierreTsr PierreTsr self-assigned this May 20, 2021
@PierreTsr PierreTsr added the enhancement New feature or request label May 20, 2021
Copy link
Collaborator

@qcappart qcappart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me ! It will be interesting to access the memory reduction that you gain with this optimization

@PierreTsr PierreTsr merged commit fe1b2c3 into master May 21, 2021
@PierreTsr PierreTsr deleted the feature/tablect_optimization branch May 21, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible TableCT optimisation
3 participants