SeaPearl cleanup and bug fix for RL value selection #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
May 7, 2021 18:13
Merged
2 tasks
ilancoulon
reviewed
May 11, 2021
src/CP/valueselection/lh_utils.jl
Outdated
| # Initialize reward for the next state: not compulsory with DefaultReward, but maybe useful in case the user forgets it | ||
| lh.reward.value = 0 | ||
|
|
||
| # synchronize state: we could delete env.state, we do not need it | ||
| # synchronize state: Update the adjacency_matrix of the CPLayerGraph using the CPModel |
There was a problem hiding this comment.
To be precise, the sync_state does not currently do that. This matrix is extracted when calling to_arraybuffer. The only thing that is (currently) synced here is the chosen variable and the possible values (two last columns of the array).
src/experiment/launch_experiment.jl
Outdated
| nodevisited[i, j] = model.statistics.numberOfNodes | ||
|
|
||
| #TODO understand what this line is doing | ||
| if j == 2 | ||
| set_postfix(iter, Delta=string(nodevisited[i, 1] - nodevisited[i, 2])) |
There was a problem hiding this comment.
This line is to update the progress bar, to show the current difference between the basic heuristic and the learned one (in terms of number of nodes).
qcappart
approved these changes
May 11, 2021
added 7 commits
May 12, 2021 17:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposition for SeaPearl cleanup. This pull request goes hand in hand with another pull request on SeaPearlZoo.
Problem : Some part of the source code were obsolete and no longer in the framework of current SeaPearl development. The RL based knapsack example was crashing and returning untrackable errors :
ERROR: BoundsError: attempt to access 328-element Vector{Int64} at index [0]Key features :
explorer.jlandlearned.jlknapsack_generator.jl, someIntVarViewwere considered as branchable