Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "Distributions" to "0.25" #116

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 3, 2021

This pull request changes the compat entry for the Distributions package from 0.24 to 0.24, 0.25.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@PierreTsr
Copy link
Contributor

PierreTsr commented May 11, 2021

The bump to the newer version is locked by ReinforcementLearningCore which isn't yet compatible. How should we handle this ? Accept the bump eventhough julia won't install v0.25 until RL.jl is updated ? Or don't, as we aren't sure on how SeaPearl will behave with the new version ?

Copy link
Contributor

@PierreTsr PierreTsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major change concerning SeaPearl according to the release notes.

@PierreTsr PierreTsr merged commit 84abc52 into master May 17, 2021
@PierreTsr PierreTsr deleted the compathelper/new_version/2021-05-03-00-49-09-793-3285328107 branch May 18, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant