Skip to content

Commit

Permalink
Remove pre-episode & post-episode stage
Browse files Browse the repository at this point in the history
  • Loading branch information
ilancoulon committed Jan 24, 2021
1 parent 69f97bd commit 6852374
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/CP/valueselection/learnedheuristic.jl
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ function (valueSelection::LearnedHeuristic)(::InitializingPhase, model::CPModel,
# Reset the agent, useful for things like recurrent networks
Flux.reset!(valueSelection.agent)

# just empty the buffer
valueSelection.agent(RL.PRE_EPISODE_STAGE, obs)
###TODO: We should investigate why this line must be removed
# valueSelection.agent(RL.PRE_EPISODE_STAGE, obs)
end

"""
Expand Down Expand Up @@ -117,6 +117,7 @@ function (valueSelection::LearnedHeuristic)(PHASE::EndingPhase, model::CPModel,

valueSelection.agent(RL.POST_ACT_STAGE, obs) # get terminal and reward

valueSelection.agent(RL.POST_EPISODE_STAGE, obs) # let the agent see the last observation
###TODO: We should investigate why this line must be removed
# valueSelection.agent(RL.POST_EPISODE_STAGE, obs) # let the agent see the last observation
end

2 comments on commit 6852374

@ilancoulon
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/34766

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.0 -m "<description of version>" 68523742abe153cd9a599d589f0b2f42981ecd63
git push origin v0.1.0

Please sign in to comment.