-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VsCoq1] Webpack Client and Server #411
Conversation
Co-authored-by: Fabian Kunze <fkunze@fkunze.de>
} | ||
"outFiles": ["${workspaceRoot}/client/out/**/*.js"], | ||
"sourceMaps": true, | ||
"preLaunchTask": "npm: watch" //The new vscode window still needs to be reloaded after changes (Ctrl+Shift+F5 in the debugger) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are comments allowed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, comments are allowed in all VS Code configuration files.
Looks very good to me! @thery any opinion? |
@maximedenes Yes pretty pretty good. 😄 I'll test it and I'll merge it. |
Is this normal?
|
I don't think it is something we should worry about. It can be solved by upgrading vscode-languageserver to a more recent version. |
@4ever2 Thanks |
@4ever2 thanks for tying up this loose end :) |
This PR rebases and slightly improves the work of @fakusb in #266.
Webpacking the extension resulted in ~80% decrease in loading time and ~96% decrease in size (from 8.9MB to 289KB).
This supersedes #69, #176 and #266.