Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VsCoq1] Webpack Client and Server #411

Merged
merged 5 commits into from
Feb 20, 2023
Merged

[VsCoq1] Webpack Client and Server #411

merged 5 commits into from
Feb 20, 2023

Conversation

4ever2
Copy link
Contributor

@4ever2 4ever2 commented Feb 19, 2023

This PR rebases and slightly improves the work of @fakusb in #266.
Webpacking the extension resulted in ~80% decrease in loading time and ~96% decrease in size (from 8.9MB to 289KB).

This supersedes #69, #176 and #266.

@4ever2 4ever2 marked this pull request as ready for review February 19, 2023 22:19
}
"outFiles": ["${workspaceRoot}/client/out/**/*.js"],
"sourceMaps": true,
"preLaunchTask": "npm: watch" //The new vscode window still needs to be reloaded after changes (Ctrl+Shift+F5 in the debugger)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are comments allowed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, comments are allowed in all VS Code configuration files.

@maximedenes
Copy link
Member

Looks very good to me! @thery any opinion?

@thery
Copy link
Contributor

thery commented Feb 20, 2023

@maximedenes Yes pretty pretty good. 😄 I'll test it and I'll merge it.

@thery
Copy link
Contributor

thery commented Feb 20, 2023

Is this normal?

WARNING in ./node_modules/vscode-languageserver/lib/files.js 84:36-54
Critical dependency: the request of a dependency is an expression
 @ ./node_modules/vscode-languageserver/lib/main.js 19:11-29
 @ ./server/src/server.ts 13:32-64

WARNING in ./node_modules/vscode-languageserver/lib/files.js 319:15-28
Critical dependency: the request of a dependency is an expression
 @ ./node_modules/vscode-languageserver/lib/main.js 19:11-29
 @ ./server/src/server.ts 13:32-64

@4ever2
Copy link
Contributor Author

4ever2 commented Feb 20, 2023

Is this normal?

I don't think it is something we should worry about. It can be solved by upgrading vscode-languageserver to a more recent version.

@thery
Copy link
Contributor

thery commented Feb 20, 2023

@4ever2 Thanks

@thery thery merged commit 41bfee3 into coq:vscoq1 Feb 20, 2023
@fakusb
Copy link

fakusb commented Mar 1, 2023

@4ever2 thanks for tying up this loose end :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants