-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable super-slow "Proof View Diff" #321
Conversation
Motivation: this option can be very slow, according to coq#317 (comment). TODO: should probably be `coq.proofViewDiff`, but `coq.proofViewDiff.XYZ` options exist and I'll test for interference later.
1884238
to
d89806e
Compare
I have a silly question: with your patch, can you still get proof diff but from Coq (which is faster if I understood correctly) or will this require yet another patch? |
@TheoWinterhalter it would need another patch, but I feel "VsCoq stops hanging for minutes" is still valuable, and a low-hanging fruit. The existing diffs still work AFAICT, and you can even tweak the setting without reloading the file. |
Can we merge? |
Assuming the bump hasn't changed things, this should be pretty safe and keep the old behavior by default. (Maybe we should change the default). |
Thanks for merging! |
SettingsState.proofViewDiff?
instead of adding a new boolean.Initial testcase
Adapted from #317 (comment) with size 500 (I didn't want to wait for 3 minutes).