Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance 2024 05 #157

Merged
merged 57 commits into from
May 3, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
8933356
update project structure
copiousfreetime May 1, 2024
bfd6fce
move launchy to exe dir
copiousfreetime May 1, 2024
7cbdf98
fix changelog uri
copiousfreetime May 1, 2024
fffb504
update manifest
copiousfreetime May 1, 2024
0bec2d5
revert ruby level
copiousfreetime May 1, 2024
cbdba48
add linux platform
copiousfreetime May 1, 2024
98d29e9
add ruby platform
copiousfreetime May 1, 2024
2ecceef
update .gitignore
copiousfreetime May 1, 2024
5de7280
remove heel and add all the platforms
copiousfreetime May 1, 2024
d22bf9e
single to double quotes
copiousfreetime May 1, 2024
4595b0a
add frozen string literal
copiousfreetime May 1, 2024
85fb2ed
whitespace cleanup
copiousfreetime May 1, 2024
fbe3672
module/class documentation
copiousfreetime May 3, 2024
9ca065a
its okay for this method
copiousfreetime May 3, 2024
f317776
whitespace fixes
copiousfreetime May 3, 2024
0ad3263
hash alignments
copiousfreetime May 3, 2024
91b0fe7
use () to indicate assignment
copiousfreetime May 3, 2024
54afd30
because tests
copiousfreetime May 3, 2024
6e4b59e
explicit return is what we want here
copiousfreetime May 3, 2024
f2e9fed
call super
copiousfreetime May 3, 2024
8703e92
rescue standard error
copiousfreetime May 3, 2024
c3ed9df
unused params
copiousfreetime May 3, 2024
b154574
changed method length in config
copiousfreetime May 3, 2024
fa472cd
use names
copiousfreetime May 3, 2024
d5f4e24
exception variable names
copiousfreetime May 3, 2024
15e3deb
change match style
copiousfreetime May 3, 2024
4d10c2b
load file
copiousfreetime May 3, 2024
e4bbcb9
group accessors
copiousfreetime May 3, 2024
e836549
removing compact style
copiousfreetime May 3, 2024
518712e
don't use colon method call
copiousfreetime May 3, 2024
70074ca
use `` for execs
copiousfreetime May 3, 2024
be249b1
env fetch
copiousfreetime May 3, 2024
46a14f4
array literal
copiousfreetime May 3, 2024
647e57b
guard clauses
copiousfreetime May 3, 2024
8059f3b
its not 1.8 anymore
copiousfreetime May 3, 2024
9809cd9
if/then cleanup
copiousfreetime May 3, 2024
86cd99e
if nots
copiousfreetime May 3, 2024
2aea74f
change to stabbys
copiousfreetime May 3, 2024
b2a68d7
use number predicates
copiousfreetime May 3, 2024
ecde465
preferred delimiters
copiousfreetime May 3, 2024
9357dd0
redundant begin
copiousfreetime May 3, 2024
ec9561f
redundant regex
copiousfreetime May 3, 2024
3ad5f34
redundant self/retur
copiousfreetime May 3, 2024
4d53409
regex
copiousfreetime May 3, 2024
6fe9ee1
expand single line methods
copiousfreetime May 3, 2024
dc8c0d6
use global names
copiousfreetime May 3, 2024
a1f8472
string literal interpolation
copiousfreetime May 3, 2024
839cce7
symbol to proc
copiousfreetime May 3, 2024
81b20b1
trailing commas
copiousfreetime May 3, 2024
eb2f9d7
use array
copiousfreetime May 3, 2024
2731f8a
use empty?
copiousfreetime May 3, 2024
4d09848
reduce line length
copiousfreetime May 3, 2024
dba7ea3
customized rubocop
copiousfreetime May 3, 2024
f6dc4d3
no longer a valid test
copiousfreetime May 3, 2024
7dc80fe
add minitest focus
copiousfreetime May 3, 2024
4af7db8
remvoe unused
copiousfreetime May 3, 2024
ddfe50a
remove debug
copiousfreetime May 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
guard clauses
  • Loading branch information
copiousfreetime committed May 3, 2024
commit 647e57b029397bda2ae64b8a4054b2b799a93970
10 changes: 4 additions & 6 deletions lib/launchy/cli.rb
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,10 @@ def parse(argv, _env)
end

def good_run(argv, env)
if parse(argv, env) then
Launchy.open(argv.shift, options) { |e| error_output(e) }
return true
else
return false
end
return false unless parse(argv, env)

Launchy.open(argv.shift, options) { |e| error_output(e) }
return true
end

def error_output(error)
Expand Down
12 changes: 6 additions & 6 deletions lib/launchy/detect/host_os.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ class HostOs
def initialize(host_os = nil)
@host_os = host_os

if not @host_os then
if (@host_os = override_host_os) then
Launchy.log "Using LAUNCHY_HOST_OS override value of '#{Launchy.host_os}'"
else
@host_os = default_host_os
end
return if @host_os

if (@host_os = override_host_os) then
Launchy.log "Using LAUNCHY_HOST_OS override value of '#{Launchy.host_os}'"
else
@host_os = default_host_os
end
end

Expand Down