-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ditch makefile in favour of poe tasks in pyproject.toml #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nat-n
changed the title
The new
Ditch makefile in favour of poe the poet
Aug 17, 2020
[tool.poe.tasks]
section and new poetry based workflow are …
nat-n
changed the title
Ditch makefile in favour of poe the poet
Ditch makefile in favour of poe tasks in pyproject.toml
Aug 17, 2020
yajo
requested changes
Aug 19, 2020
yajo
reviewed
Aug 20, 2020
yajo
requested changes
Aug 21, 2020
The new `[tool.poe.tasks]` section and new poetry based workflow are a complete replacement for the makefile which has also been removed. copier-org#129 Also: - add devtasks for python functions to be referenced as poe tasks - update CONTRIBUTING.MD copier-org#154 to keep things coherent - remove reference to tox - update ci to work with more expressive toml syntax (upgrade pip) - and use poe tasks in ci
yajo
approved these changes
Aug 21, 2020
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on a task runner that I think based on the discussion in #129 would be a good fit for this project :)
I also took a stab at #154 to keep things coherent. I'm happy to iterate if there are things we'd prefer to differently.
Poe is a task runner that works well with poetry.
Key features
poetry run
unless already inside a poetry shellSummary of changes in this PR
[tool.poe.tasks]
section in the pyproject.toml functionally replicates the old make file._
which means they're hidden and not directly runnable, though this is not necessary if we think using them directly would be usefulOther Features
Note that poe also supports:
It's also possible to define new tasks using other toml syntax forms like:
Try it out:
pip install poethepoet poe test