Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] delivery_product_restriction #221

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

remytms
Copy link
Member

@remytms remytms commented Mar 30, 2022

Description

It allows some product to be shipped only by some delivery carrier. If such a product is found in a SO then the SO can only be shipped via these delivery carrier.

To get this features works in the eCommerce install the website_sale_delivery_product_restriction module.

Odoo task (if applicable)

https://gestion.coopiteasy.be/web#id=8260&view_type=form&model=project.task&action=475&active_id=231

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • (If a new module) Moving this to OCA has been considered.

@remytms
Copy link
Member Author

remytms commented Mar 30, 2022

This module may interest OCA.

@remytms remytms force-pushed the 12.0-add-delivery_product_restriction branch from 17d275e to 998fe8f Compare March 30, 2022 16:25
Copy link
Member

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few comments about this one :-)

@remytms remytms force-pushed the 12.0-add-delivery_product_restriction branch 2 times, most recently from c5db26e to 707e2db Compare April 14, 2022 14:56
@remytms
Copy link
Member Author

remytms commented Apr 14, 2022

@robinkeunen I've answered your questions. Can you tell me if my answer satisfy you, or if we should investigate more.

@robinkeunen robinkeunen self-requested a review April 14, 2022 15:28
Copy link
Member

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convinced by your justifications 👍

@robinkeunen robinkeunen self-requested a review April 14, 2022 15:29
Copy link
Member

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convinced by your justifications.

@remytms remytms force-pushed the 12.0-add-delivery_product_restriction branch from 707e2db to e6ef631 Compare April 14, 2022 16:44
@remytms remytms merged commit 02747aa into 12.0 Apr 19, 2022
@remytms remytms deleted the 12.0-add-delivery_product_restriction branch April 19, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants