feat: add AnnouncementBar to viewport of extjs-comp-navport

refs conjoon/extjs-comp-navport#15
coon-js · Oct 29, 2021 · ff1db38 · ff1db38
1 parent 75a6eef
commit ff1db38
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 10 deletions.
diff --git a/src/view/NavigationViewport.js b/src/view/NavigationViewport.js
@@ -32,6 +32,8 @@
  * leaving a content panel with an {@link Ext.layout.container.Card}-layout.
  *
  *      +-----------------------------------------+
+ *      |           announcement bar              |
+ *      +-----------------------------------------+
  *      |                toolbar                  |
  *      +-----------------------------------------+
  *      |        |                                |
@@ -119,6 +121,7 @@ Ext.define("coon.navport.view.NavigationViewport", {
     alias: "widget.cn_navport",
 
     requires: [
+        "coon.comp.component.AnnouncementBar",
         "coon.navport.view.NavigationToolbar",
         "coon.navport.view.controller.NavigationViewportController",
         "coon.navport.view.ContentWrap",
@@ -138,6 +141,8 @@ Ext.define("coon.navport.view.NavigationViewport", {
     },
 
     items: [{
+        xtype: "cn_comp-announcementbar"
+    }, {
         reference: "cn_navport_ref_tbar",
         xtype: "cn_navport-tbar"
     }, {
@@ -147,6 +152,19 @@ Ext.define("coon.navport.view.NavigationViewport", {
     }],
 
 
+    /**
+     * @inheritdoc
+     */
+    initComponent () {
+
+        const me = this;
+        me.callParent(arguments);
+
+        coon.Announcement.register(me.down("cn_comp-announcementbar"));
+
+    },
+
+
     /**
      * Consumes a javascript native object and passes the entries found within
      * to the #buildNavigationItems ans #buildNavItems
@@ -158,9 +176,10 @@ Ext.define("coon.navport.view.NavigationViewport", {
      * @throws bubbles the ecxeptions od #buildNavigationItems and
      * #buildPermaNavItems
      */
-    addPostLaunchInfo: function (info) {
+    addPostLaunchInfo (info) {
+        "use strict";
 
-        var me = this;
+        const me = this;
 
         if (Object.prototype.hasOwnProperty.call(info,"navigation")) {
             me.getController().addMainNavigationItems(info.navigation);
@@ -180,7 +199,8 @@ Ext.define("coon.navport.view.NavigationViewport", {
      *
      * see {@link coon.navport.view.controller.NavigationViewportController#hideNavigation}
      */
-    hideNavigation: function (hide) {
+    hideNavigation (hide) {
+        "use strict";
         this.getController().hideNavigation(hide);
     },
 
@@ -198,7 +218,8 @@ Ext.define("coon.navport.view.NavigationViewport", {
      *
      * @return {coon.navport.view.pages.Page404}
      */
-    showUnmatchedRouteNotification: function (missingHash, defaultToken) {
+    showUnmatchedRouteNotification (missingHash, defaultToken) {
+        "use strict";
 
         return Ext.create("coon.navport.view.pages.Page404", {
             title: Ext.String.format("\"{0}\" not found", missingHash),
@@ -212,8 +233,9 @@ Ext.define("coon.navport.view.NavigationViewport", {
      *
      * @see coon.navport.view.controller.NavigationViewportController#addViewForHash
      */
-    activateViewForHash: function (hash, defaultToken) {
-        var me = this;
+    activateViewForHash (hash, defaultToken) {
+        "use strict";
+        const me = this;
         me.cleanup();
         return me.getController().addViewForHash(hash, defaultToken);
     },
@@ -225,8 +247,10 @@ Ext.define("coon.navport.view.NavigationViewport", {
      * @see coon.navport.view.controller.NavigationViewportController#isCurrentViewClosable
      * @see coon.navport.view.controller.NavigationViewportController#ctrl.closeCurrentView();
      */
-    cleanup: function () {
-        var me   = this,
+    cleanup () {
+        "use strict";
+        const
+            me   = this,
             ctrl = me.getController();
 
         if (ctrl.isCurrentViewClosable()) {

diff --git a/tests/src/view/NavigationViewportTest.js b/tests/src/view/NavigationViewportTest.js
@@ -81,6 +81,15 @@ StartTest((t) => {
         t.expect(viewport.lookup("cn_navport_ref_tbar") instanceof coon.navport.view.NavigationToolbar).toBe(true);
     });
 
+    t.it("Should have the AnnouncementBar", (t) => {
+
+        const announcementSpy = t.spyOn(coon.Announcement, "register");
+        viewport = Ext.create("coon.navport.view.NavigationViewport");
+        t.isInstanceOf(viewport.down("cn_comp-announcementbar"), "coon.comp.component.AnnouncementBar");
+        t.expect(announcementSpy.calls.count()).toBe(1);
+        t.expect(announcementSpy.calls.all()[0].args[0]).toBe(viewport.down("cn_comp-announcementbar"));
+        announcementSpy.remove();
+    });
 
     t.it("Should be possible to hide the navigation", (t) => {
         viewport = Ext.create("coon.navport.view.NavigationViewport", Ext.isModern ? {

diff --git a/tests/tests.config.js b/tests/tests.config.js
@@ -56,6 +56,7 @@ export default {
         },
 
         classic: {
+            "coon.comp.component.AnnouncementBar": "../node_modules/@coon-js/extjs-lib-comp/classic/src/component/AnnouncementBar.js",
             "coon.navport.view.NavigationToolbar": "../classic/src/view/NavigationToolbar.js",
             "coon.comp.container.Viewport": "../node_modules/@coon-js/extjs-lib-comp/classic/src/container/Viewport.js"
         }
@@ -65,5 +66,3 @@ export default {
         js: "../node_modules/@l8js/l8/dist/l8.runtime.umd.js"
     }
 };
-
-