Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for minor/preminor versions for custom templates #185

Merged
merged 2 commits into from
May 21, 2021

Conversation

sri-vr
Copy link
Contributor

@sri-vr sri-vr commented Oct 21, 2020

hey there,

i have added minor version support for custom templates, so that the custom templates could use it to differentiate and show accordingly (for eg font size diff for patch and minor and major) ,

kindly take a look,
thanks,

@ljharb
Copy link
Contributor

ljharb commented Oct 21, 2020

what is a "preminor"?

@sri-vr
Copy link
Contributor Author

sri-vr commented Oct 21, 2020

what is a "preminor"?

hey , its semver prelease type, see https://www.npmjs.com/package/semver#functions

for eg:
semver.Diff('0.0.1', '0.1.0');
//=> 'minor'

semver.Diff('0.0.1-foo', '0.1.0');
//=> 'preminor'

i added it here because it will be useful for tag patterns
for eg
tag 1: 1.1.0-foo
and tag 2 : 1.2.0-foo
normally if preminor is not added the minor flag wont be true and it would work only for 1.1.0$ to 1.2.0$

@ljharb
Copy link
Contributor

ljharb commented Oct 21, 2020

ah ok, so it's a prerelease for a minor bump.

@sri-vr
Copy link
Contributor Author

sri-vr commented Oct 21, 2020

ah ok, so it's a prerelease for a minor bump.

yup

@cookpete cookpete merged commit 44e8085 into cookpete:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants