Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 compatibility. #85

Closed
wants to merge 8 commits into from
Closed

Python3 compatibility. #85

wants to merge 8 commits into from

Conversation

1ozturkbe
Copy link
Contributor

Had a few minutes, figured it could use a futurize.

@acdl-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@acdl-jenkins
Copy link

Can one of the admins verify this patch?

@bqpd
Copy link
Contributor

bqpd commented Sep 11, 2019 via email

@bqpd
Copy link
Contributor

bqpd commented Sep 11, 2019 via email

Copy link
Collaborator

@whoburg whoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks @1ozturkbe

# Conflicts:
#	docs/source/examples/hoburgabbeel_ex6_1.py
#	gpfit/examples/ex61setup.py
#	gpfit/fit_constraintset.py
#	gpfit/implicit_softmax_affine.py
#	gpfit/levenberg_marquardt.py
#	gpfit/lse_implicit.py
#	gpfit/lse_scaled.py
#	gpfit/max_affine.py
#	gpfit/plot_fit.py
#	gpfit/softmax_affine.py
#	gpfit/xfoil_wrapper.py
@1ozturkbe
Copy link
Contributor Author

test this please

@1ozturkbe
Copy link
Contributor Author

I'm not sure why tests aren't triggering for this repo... I ran them locally and all changes should be good. Just need the checks to complete. @bqpd?

@whoburg
Copy link
Collaborator

whoburg commented Feb 5, 2020

test this please

@1ozturkbe
Copy link
Contributor Author

@priyappillai please don't forget to commit merges so that tests can run :)

@priyappillai
Copy link

sorry! although, is this obsolete from #86 ?

@1ozturkbe
Copy link
Contributor Author

hmmm why did this PR exist then? Let me check master compatibility and then close this.

@1ozturkbe
Copy link
Contributor Author

Master is good. I'm going to check PR testing on this repo in a few mins and close this.

@1ozturkbe 1ozturkbe closed this Feb 6, 2020
@1ozturkbe 1ozturkbe deleted the python3 branch February 6, 2020 14:52
@1ozturkbe 1ozturkbe restored the python3 branch February 6, 2020 16:18
@1ozturkbe 1ozturkbe reopened this Feb 6, 2020
@pgkirsch
Copy link
Contributor

@1ozturkbe did you mean to reopen this or can it be closed again?

@1ozturkbe
Copy link
Contributor Author

I have no idea why this was reopened... feel free to close if it works for Py3, which I believe it does now! (Haven't been using this lately.)

@pgkirsch
Copy link
Contributor

Thanks, done!

@pgkirsch pgkirsch closed this Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants