-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 compatibility. #85
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
whitelist
…On Wed, Sep 11, 2019, 17:08 acdl-jenkins ***@***.***> wrote:
Can one of the admins verify this patch?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#85?email_source=notifications&email_token=AALKAGCXMWGJSQKPUGQQNPDQJF24NA5CNFSM4IVZZ5A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6QE6DY#issuecomment-530599695>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALKAGBK3PWZQLCKHBHUUFDQJF24NANCNFSM4IVZZ5AQ>
.
|
thanks Berk!
…On Wed, Sep 11, 2019, 17:55 Edward Burnell ***@***.***> wrote:
whitelist
On Wed, Sep 11, 2019, 17:08 acdl-jenkins ***@***.***> wrote:
> Can one of the admins verify this patch?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#85?email_source=notifications&email_token=AALKAGCXMWGJSQKPUGQQNPDQJF24NA5CNFSM4IVZZ5A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6QE6DY#issuecomment-530599695>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AALKAGBK3PWZQLCKHBHUUFDQJF24NANCNFSM4IVZZ5AQ>
> .
>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Thanks @1ozturkbe
# Conflicts: # docs/source/examples/hoburgabbeel_ex6_1.py # gpfit/examples/ex61setup.py # gpfit/fit_constraintset.py # gpfit/implicit_softmax_affine.py # gpfit/levenberg_marquardt.py # gpfit/lse_implicit.py # gpfit/lse_scaled.py # gpfit/max_affine.py # gpfit/plot_fit.py # gpfit/softmax_affine.py # gpfit/xfoil_wrapper.py
test this please |
I'm not sure why tests aren't triggering for this repo... I ran them locally and all changes should be good. Just need the checks to complete. @bqpd? |
test this please |
@priyappillai please don't forget to commit merges so that tests can run :) |
sorry! although, is this obsolete from #86 ? |
hmmm why did this PR exist then? Let me check master compatibility and then close this. |
Master is good. I'm going to check PR testing on this repo in a few mins and close this. |
@1ozturkbe did you mean to reopen this or can it be closed again? |
I have no idea why this was reopened... feel free to close if it works for Py3, which I believe it does now! (Haven't been using this lately.) |
Thanks, done! |
Had a few minutes, figured it could use a futurize.