Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fluxcd/pkg/runtime/cel for ResourceSet dependencies ready expression evaluation #159

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Use fluxcd/pkg/runtime/cel for ResourceSet dependencies ready expression evaluation #159

merged 1 commit into from
Jan 31, 2025

Conversation

matheuscscp
Copy link
Member

No description provided.

matheuscscp
matheuscscp commented Jan 28, 2025
View reviewed changes
@matheuscscp matheuscscp force-pushed the cel-pkg branch 2 times, most recently from 2e71150 to b4d16b8 Compare January 31, 2025 11:10
@stefanprodan stefanprodan added the area/resourceset ResourceSet related issues and PRs label Jan 31, 2025
@stefanprodan stefanprodan changed the title Use fluxcd/pkg/runtime/cel for ResourceSet dependencies ready expression evaluation Use fluxcd/pkg/runtime/cel for ResourceSet dependencies ready expression evaluation Jan 31, 2025
stefanprodan
stefanprodan approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp

@matheuscscp matheuscscp force-pushed the cel-pkg branch 2 times, most recently from 0b83e06 to 2bf8a34 Compare January 31, 2025 12:00
@stefanprodan
Copy link
Member

Please bump all fluxcd/pkg

@matheuscscp
Use fluxcd/pkg/runtime/cel for ResourceSet dependencies ready express…
d680278 
…ion evaluation

Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp matheuscscp merged commit 3a8b7ea into main Jan 31, 2025
1 check passed
@matheuscscp matheuscscp deleted the cel-pkg branch January 31, 2025 13:15
@stefanprodan stefanprodan mentioned this pull request Feb 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/resourceset ResourceSet related issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheuscscp @stefanprodan