This repository has been archived by the owner on Nov 11, 2023. It is now read-only.
Add a clean way to consolidate data in Poll
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
TejasQ
reviewed
Sep 12, 2018
| this.keepPolling = false; | ||
| this.setState(() => ({ polling: false, finished: true })); // let everyone know we're done here. | ||
| }; | ||
|
|
||
| public componentDidMount() { | ||
| const { path, lazy } = this.props; | ||
|
|
||
| if (!path) { | ||
| if (path === undefined) { |
There was a problem hiding this comment.
But path is required in the interface 🤔
There was a problem hiding this comment.
Really? Why can we not poll on the base? It's works for Get so…
There was a problem hiding this comment.
I keep the path mandatory to avoid mistake, so we need to path="" if we want this case (a bit stupid but explicit)
There was a problem hiding this comment.
Ah, I may have your comment, it's for javascript users ^^ (this case is not possible in typescript of course)
TejasQ
approved these changes
Sep 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Our server send us chunk instead of a complete response on long polling (for obvious performance reasons ^^)
The idea is to have
prevDataavailable in thePoll:resolveprops, so we can do:I also add a lot of unit tests to
Polland fix some little behaviour on my way: