-
Notifications
You must be signed in to change notification settings - Fork 109
#261 - processResponse support blob & Co #262
Conversation
Deploy request for restful-react accepted. Accepted with commit c549779 https://app.netlify.com/sites/restful-react/deploys/5eafd897707a670006f14f18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, almost perfect 😁
- if the content-type is "application/json" or "text/plain" behavior will not change. - all other cases will return whole response object.
@fabien0102 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
No ideas why the tests are not running, I will try this WE, don't have any computer where I am... (And I will publish a new package as soon as merge this PR 😉) Thanks again for your contribution 😃 |
Cool. |
- fix tests
All tests should pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks again for this contribution, I will publish a new version (probably a major one, since this could break some setup (if the server don't send the correct headers))
Why
See: #261