Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

#261 - processResponse support blob & Co #262

Merged
merged 2 commits into from
May 4, 2020
Merged

Conversation

cbek
Copy link
Contributor

@cbek cbek commented Apr 20, 2020

  • if the content-type is "application/json" or "text/plain" behavior will not change.
  • all other cases will return whole response object.

Why

See: #261

@netlify
Copy link

netlify bot commented Apr 20, 2020

Deploy request for restful-react accepted.

Accepted with commit c549779

https://app.netlify.com/sites/restful-react/deploys/5eafd897707a670006f14f18

Copy link
Contributor

@fabien0102 fabien0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, almost perfect 😁

src/util/processResponse.ts Show resolved Hide resolved
- if the content-type is "application/json" or "text/plain" behavior will not change.
- all other cases will return whole response object.
@cbek
Copy link
Contributor Author

cbek commented Apr 22, 2020

@fabien0102
Better?

fabien0102
fabien0102 previously approved these changes Apr 22, 2020
Copy link
Contributor

@fabien0102 fabien0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@fabien0102
Copy link
Contributor

No ideas why the tests are not running, I will try this WE, don't have any computer where I am... (And I will publish a new package as soon as merge this PR 😉)

Thanks again for your contribution 😃

@cbek
Copy link
Contributor Author

cbek commented Apr 22, 2020

No ideas why the tests are not running, I will try this WE, don't have any computer where I am... (And I will publish a new package as soon as merge this PR 😉)

Thanks again for your contribution 😃

Cool.
Thanks.

@fabien0102
Copy link
Contributor

image

Two tests are failing, we need to check if they are still relevant or not 😉

@cbek
Copy link
Contributor Author

cbek commented May 4, 2020

All tests should pass now.

Copy link
Contributor

@fabien0102 fabien0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again for this contribution, I will publish a new version (probably a major one, since this could break some setup (if the server don't send the correct headers))

@fabien0102 fabien0102 merged commit 5d26fee into contiamo:master May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants