Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

Update React peer dependency #182

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Update React peer dependency #182

merged 2 commits into from
Nov 20, 2019

Conversation

owinter86
Copy link
Contributor

@owinter86 owinter86 commented Nov 19, 2019

Why

This addresses issue here #181, this will ensure that future react native versions are supported and no longer installs multiple React versions, but unsure if this will have other implications

This addresses issue here #181, this will ensure that future react native versions are supported and no longer installs multiple React versions, but unsure if this will have other implications
@fabien0102 fabien0102 requested a review from TejasQ November 19, 2019 14:34
@TejasQ
Copy link
Contributor

TejasQ commented Nov 19, 2019

Hey @owinter86! Thanks so much for your pull request. I'm a little bit apprehensive about removing React as a peer dependency here because React is not listed under dependencies in package.json at all (this is a separate issue – it should be because we're using it 😅).

What if instead of removing the peer dependency, we bump it to the lowest compatible version of React for web and native? I believe this is 16.9.x? In which case, >=16.9.0 should be what we need.

That might be safer. What do you think?

@owinter86
Copy link
Contributor Author

Yep sounds good to me, do I need to update the PR

@TejasQ
Copy link
Contributor

TejasQ commented Nov 19, 2019

Yes, because the PR removes it currently. 😬

Change peer dependency to include 16+ versions of react
@owinter86
Copy link
Contributor Author

I have updated to include peer dependency of react 16.8+ as I believe >=16.9.0 will likely no work for the next RN update. I think you need React version that is compatible with hooks for this package to run, so hopefully this peer dependency change is ok.

@owinter86 owinter86 changed the title Remove React as a peer dependency Update React peer dependency Nov 19, 2019
@TejasQ
Copy link
Contributor

TejasQ commented Nov 20, 2019

Great work!

@TejasQ TejasQ merged commit a67606b into contiamo:master Nov 20, 2019
@owinter86 owinter86 deleted the patch-1 branch November 25, 2019 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants