This repository has been archived by the owner on Nov 11, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The following of #17
Note
I've have removed the throwing inside
fetch
, it was a bit weird and really hard to test. In fact I wondering how it works in real world?BTW, I think that in this context, it's not really practicle and I prefer to deal with a simple
error
object.I think that the original idea was to do this:
But it's more natural to deal with error in the first level like this:
And, because we use
this.fetch
for therefresh
and the "initial fetch" it's really hard to catch an error for this first fetch 😉