Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

fix/132 handle fetch error mutate #134

Merged
merged 2 commits into from
Jul 3, 2019
Merged

fix/132 handle fetch error mutate #134

merged 2 commits into from
Jul 3, 2019

Conversation

mpotomin
Copy link
Contributor

@mpotomin mpotomin commented Jul 3, 2019 •
edited
Loading

Why

  1. Wraps fetch call into try/catch to handle if fetch call returns an error, i.e when offline. Also passes the error to the RestfulProvider.
  2. Makes response optional for the error callback for this case

Issue

#132

How to test:

See the case in the linked issue

@mpotomin mpotomin requested review from fabien0102 and TejasQ July 3, 2019 11:21
@mpotomin mpotomin self-assigned this Jul 3, 2019
TejasQ
TejasQ approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@TejasQ TejasQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@mpotomin mpotomin merged commit 239d0fb into master Jul 3, 2019
@mpotomin mpotomin deleted the fix/132-handle-offline-2 branch July 3, 2019 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TejasQ TejasQ TejasQ approved these changes

@fabien0102 fabien0102 Awaiting requested review from fabien0102

Assignees

@mpotomin mpotomin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpotomin @TejasQ