Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

Update lodash #105

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Update lodash #105

merged 1 commit into from
Mar 15, 2019

Conversation

stereobooster
Copy link
Contributor

@stereobooster stereobooster commented Mar 15, 2019

Why

Github security alert doesn't take into account yarn.lock. In yarn.lock it already has proper version. Same goes for extend package

Screenshot 2019-03-15 at 10 29 38

And it doesn't catch some alerts which yarn catches

yarn audit
yarn audit v1.13.0
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ high          │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ handlebars                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=4.0.13                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @operational/scripts                                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ @operational/scripts > webpack-dashboard > handlebars        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/755                       │
└───────────────┴──────────────────────────────────────────────────────────────┘
1 vulnerabilities found - Packages audited: 491062
Severity: 1 High

@TejasQ TejasQ merged commit 898079f into master Mar 15, 2019
@TejasQ TejasQ deleted the security-audit branch March 15, 2019 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants