Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(date): allow arbitrary date range [ZEND-5700] #1806

Merged
merged 1 commit into from
Nov 28, 2024
Merged

feat(date): allow arbitrary date range [ZEND-5700] #1806

merged 1 commit into from
Nov 28, 2024

Conversation

z0al
Copy link
Member

@z0al z0al commented Nov 28, 2024 •
edited
Loading

In a follow up we will consider respecting the content model validation settings

@z0al z0al requested a review from a team as a code owner November 28, 2024 16:07
@z0al z0al marked this pull request as draft November 28, 2024 16:23
@z0al z0al closed this Nov 28, 2024
@z0al z0al reopened this Nov 28, 2024
@z0al z0al marked this pull request as ready for review November 28, 2024 16:59
aodhagan-cf
aodhagan-cf approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@aodhagan-cf aodhagan-cf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: maybe feels more like a feature than a fix

@z0al z0al changed the title fix(date): remove hard-coded date range [ZEND-5700] feat(date): allow arbitrary date range [ZEND-5700] Nov 28, 2024
@z0al z0al merged commit 9bbb2a1 into master Nov 28, 2024
16 checks passed
@z0al z0al deleted the fix(date)--remove-hard-coded-range branch November 28, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aodhagan-cf aodhagan-cf aodhagan-cf approved these changes

Assignees
No one assigned
Labels
package:date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z0al @aodhagan-cf