test: [TOL-1361] Rich Text editor component tests #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking pull request as stale since there was no activity for 30 days |
colomolo
commented
Feb 15, 2024
|
|
||
| // Skipping this test because of weird Plate behavior. Will describe it in a follow up PR. | ||
| // eslint-disable-next-line mocha/no-skipped-tests | ||
| it.skip('does not delete table header cells when selecting the whole table', () => { |
There was a problem hiding this comment.
Plate behavior with Cmd+A and Backspace inside of tables is not very consistent and this test fails due to this. Will be addressed in a follow up PR.
colomolo
commented
Feb 19, 2024
| it('it raises the non-first list item entirely', () => { | ||
| // FIX: Broken, skipping for now | ||
| // eslint-disable-next-line mocha/no-skipped-tests | ||
| it.skip('it raises the non-first list item entirely', () => { |
There was a problem hiding this comment.
Not clear what exactly this test should check, and what is expected result, but it's not working.
colomolo
commented
Feb 20, 2024
| // FIX: Add embed dialog mock to emulate entity selection/cancel embed | ||
| // Removed here: https://github.com/contentful/field-editors/pull/1565 | ||
| // eslint-disable-next-line mocha/no-skipped-tests | ||
| it.skip('cancels without adding the entry block', () => { |
There was a problem hiding this comment.
Skipping these cancel tracking tests, because we don't have an entry selection dialog mocked. Probably worth addressing in the next PRs.
z0al
reviewed
Feb 20, 2024
cypress/component/rich-text/RichTextEditor.EmbeddedResourceBlocks.spec.ts
Show resolved
Hide resolved
z0al
reviewed
Feb 22, 2024
This reverts commit 040940c.
z0al
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving Rich Text e2e test suites to component tests.
All e2e cleanups and test adjustments would be done in a follow up PRs.